Skip to content

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Oct 30, 2025

This moves the internal libcu++ configuration into its own file

It also splits some of the configurations for e.g thread API and atomimcs into their own file

@miscco miscco requested review from a team as code owners October 30, 2025 10:44
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 30, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 30, 2025
@miscco miscco requested a review from wmaxey October 30, 2025 10:45
@miscco miscco force-pushed the move_libcudacxx_config branch 4 times, most recently from 1c86928 to 52e47ab Compare October 30, 2025 14:37
Copy link
Contributor

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake + infra (c2h) lgtm

Copy link
Contributor

@fbusato fbusato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a more detailed description next time. We cannot review 1000+ files.

@oleksandr-pavlyk
Copy link
Contributor

One of the modified files, python/cuda_cccl/build.log, file was first added by @shwina in 3f37825. What purpose does it serve in the repo?

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Python perspective.

@github-actions
Copy link
Contributor

😬 CI Workflow Results

🟥 Finished in 4h 51m: Pass: 99%/263 | Total: 10d 17h | Max: 4h 50m | Hits: 39%/380446

See results here.

@miscco miscco force-pushed the move_libcudacxx_config branch from 52e47ab to 22b4f2b Compare November 3, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

4 participants