-
Notifications
You must be signed in to change notification settings - Fork 285
Move the libcu++ specific config #6396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1c86928 to
52e47ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake + infra (c2h) lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide a more detailed description next time. We cannot review 1000+ files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from Python perspective.
😬 CI Workflow Results🟥 Finished in 4h 51m: Pass: 99%/263 | Total: 10d 17h | Max: 4h 50m | Hits: 39%/380446See results here. |
This drops most of them because they were unused
52e47ab to
22b4f2b
Compare
This moves the internal libcu++ configuration into its own file
It also splits some of the configurations for e.g thread API and atomimcs into their own file