Skip to content

[clang-format] WrapNamespaceBodyWithEmptyLines: Never #6439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2025
Merged

[clang-format] WrapNamespaceBodyWithEmptyLines: Never #6439

merged 3 commits into from
Nov 3, 2025
+2 −1,549

Conversation

@bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Nov 2, 2025 •
edited
Loading

I found this new option in clang-format 19 and would like to enforce it for consistency. See docs here.

I don't mind too much if we choose Never or Always, but it would be good to enforce one style. Never removes about 1.5kLOCs, Always adds about 1kLOC, so we are very inconsistent at the moment.

The current PR proposed Never.

@bernhardmgruber bernhardmgruber requested review from a team as code owners November 2, 2025 11:41
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 2, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Nov 2, 2025
@github-actions

This comment has been minimized.

Sign in to view
miscco
miscco approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see new formatting guidlines I hite approve

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) November 3, 2025 13:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🥳 CI Workflow Results

🟩 Finished in 2h 12m: Pass: 100%/218 | Total: 1d 03h | Max: 45m 50s | Hits: 99%/380297

See results here.

@bernhardmgruber bernhardmgruber merged commit 31dd1d7 into NVIDIA:main Nov 3, 2025
457 of 460 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 3, 2025
@bernhardmgruber bernhardmgruber deleted the format_ns_empty_line branch November 3, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miscco miscco miscco approved these changes

@shwina shwina shwina approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-codeowners

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-c-codeowners

@pciolkosz pciolkosz Awaiting requested review from pciolkosz pciolkosz is a code owner automatically assigned from NVIDIA/cccl-cudax-codeowners

@fbusato fbusato Awaiting requested review from fbusato fbusato is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-thrust-codeowners

Assignees

No one assigned

Labels

None yet

Projects

CCCL
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bernhardmgruber @miscco @shwina