Correct CCA, TRCA and MsetCCA pipelines #625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbarthelemy
reviewed
Jun 17, 2024
| self.classes_.append(i) | ||
| self.one_hot[k] = i | ||
| self.one_hot_ = {} | ||
| self.le_, self.slen_, self.freqs_ = None, None, [] |
There was a problem hiding this comment.
Are these private or public attributes?
Private attributes have underscore before their names.
Otherwise, public attributes, with underscore after, must be added in docstring.
Suggested change
| self.le_, self.slen_, self.freqs_ = None, None, [] | |
| self._le, self._slen, self._freqs = None, None, [] |
| # Pick trial | ||
| X_test = X[trial_n, :, :] | ||
|
|
||
| for X_test in X: |
There was a problem hiding this comment.
Suggested change
| for X_test in X: | |
| for x in X: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Epochs instead of numpy for CCA, TRCA and MsetCCA, fix label estimation.