Update evaluation to use new splitters and include updates #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Within-Session is so complicated to refactor.... |
PierreGtch
requested changes
May 3, 2025
Co-authored-by: Pierre Guetschel <[email protected]> Signed-off-by: Bru <[email protected]>
PierreGtch
approved these changes
May 3, 2025
|
I think with this, we solved the parallel issue for the main functions' evaluation functions. The main question is how we can handle grid_search that has some parallel behaviour. I feel we should mix a parallel backend in this context (loky main and thread for gridsearch). Like, how I pushed.... |
|
@bruAristimunha I think we discussed about deprecating grid search at some point, such that it would be included in the pipelines directly, not the evaluations |
Signed-off-by: Bru <[email protected]>
|
I push the comments about gridsearch to another issue... Too complicated for now, let's start to use the splitter that we spent a lot of time doing >.< |
…imunha/moabb into using-the-new-splitters
PierreGtch
reviewed
May 6, 2025
Co-authored-by: Thomas Moreau <[email protected]> Signed-off-by: Bru <[email protected]>
PierreGtch
approved these changes
May 8, 2025
Signed-off-by: Bru <[email protected]>
Signed-off-by: Bru <[email protected]>
Signed-off-by: Bru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the evaluation process to utilize new cross-session and cross-subject splitters. Include updates in the "What's New" section to reflect these enhancements.