-
Notifications
You must be signed in to change notification settings - Fork 214
Added two c-VEP datasets from Martinez-Cagigal 2025 #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Hey @vicmarcag, Looks like the conversion is made only once using the Medusa kernel, and it looks like we have dependency conflicts between Medusa and moabb. I see two solutions to the problem:
What do you prefer @vicmarcag? |
@sebVelut, can you review? two very big c-vep dataset for moabb :) |
Hi, First option is not possible, I'd go for the second. I have now stated medusa-kernel>=1.3 dependency instead of 1.4 so it can be used with python 3.8 and 3.9. Should I create another pull request or is it possible to update this one in this same thread? |
ok ok, looks like Medusa is not super heavy, and now it is working fine. If I understand correctly, we need Medusa because some meta information cannot possible to be loaded with normal MNE, right? In the future, do you think this new feature from mne could be helpful? |
sessions_per_subject=len(CONDITIONS), | ||
events={}, | ||
code="MartinezCagigal2023Checkercvep", | ||
interval=(0, 1), # Don't use this, it depends on the condition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vicmarcag maybe we could have one dataset per condition, to simplify things for users. This would be quite easy with subclasses:
MartinezCagigal2023CBase # Abstract class, defines all the logic
MartinezCagigal2023C1 # Subclass, only contains runs from condition 1
MartinezCagigal2023C2 # Subclass, only contains runs from condition 2
...
what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am supporting this idea to be able to decrease the number of operation to do after getting the data
super().__init__( | ||
subjects=list(range(1, len(SUBJECTS) + 1)), | ||
sessions_per_subject=len(CONDITIONS), | ||
events={}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The events
arg must be provided, otherwise the paradigms and benchmarks will not work with this dataset
Yes ! I am looking at it as soon as I can ! 😄 |
I have added two brand new c-VEP datasets from Martínez-Cagigal (2025a,b), summing up to 32 subjects and 13 conditions per each:
I have also updated the
summary_cvep.csv
file, as well aspyproject.toml
to require a dependency ofmedusa-kernel
to load the original signals and then convert them to MNE format.