Skip to content

Make 'gdal raster/vector clip' work with --like dataset being a PostgreSQL (vector) dataset #13104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make 'gdal raster/vector clip' work with --like dataset being a PostgreSQL (vector) dataset #13104

wants to merge 1 commit into from
+67 −0

Conversation

rouault
Copy link
Member

@rouault rouault commented Sep 20, 2025

Fixes #13091

@rouault rouault added funded through GSP Work funded through the GDAL Sponsorship Program gdal_cli Anything related to the new 3.11 "gdal" CLI frontend backport release/3.11 Backport to release/3.11 branch labels Sep 20, 2025
elpaso
elpaso reviewed Sep 22, 2025
View reviewed changes
gcore/gdalalgorithm.cpp
// driver whereas the PostgreSQL (vector) one is actually wanted.
if (poDS->GetRasterCount() == 0 && (flags & GDAL_OF_RASTER) != 0 &&
(flags & GDAL_OF_VECTOR) != 0 && aosAllowedDrivers.empty() &&
aosOpenOptions.empty())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to check for OO empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't too sure if it was appropriate to test another driver with the open options that could have been set for another one. In the particular case of the original issue, the --like operator doesn't support passing open options anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport release/3.11 Backport to release/3.11 branch funded through GSP Work funded through the GDAL Sponsorship Program gdal_cli Anything related to the new 3.11 "gdal" CLI frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: gdal raster clip - fails to clip raster using PG vector data source
2 participants
@rouault @elpaso