-
-
Notifications
You must be signed in to change notification settings - Fork 372
tests: switch to new GRASS test project with srid #6593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test of the easiest fix would be to adjust the reference values in the test? |
wenzeslaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Related tests have been adjusted, but two tests are failing on ubuntu his could be related to recent parallelization of on macOS This is the 16th siginifcant digit and thus at the border of floating point precision limits, the precision for comparison should be reduced. @wenzeslaus can you please approve the latest changes? Thanks! |
|
i.smap is flaky for months, just a rerun would work. If the 16th digit is the problem with these changes, just adjust the expected precision |
|
All checks and tests have been passed, finally! Don't touch anymore, approve please, then it will be merged and I can proceed with other PRs depending on this one. This was much more effort than initially expected. |
The previous GRASS test project
nc_spm_full_v2alpha2did not have a spatial reference ID (SRID) and had thus an incomplete CRS definition with incorrect datum. The official sample datasetsnc_basic_spm_grass7andnc_spm_08_grass7do have a SRID set (EPSG:3358). A side effect is that import of data into the test project that have been exported from the sample datasets would fail with strict testing for matching CRSs. This PR uses the newnc_spm_full_v2beta1test project created and uploaded by @neteler and me.