Skip to content

Conversation

@wvpm
Copy link
Contributor

@wvpm wvpm commented Oct 16, 2025

Replaces #574

#545 added tracking balance history per country.
Also price history is tracked since #288

They used ValueHistory which is flawed in several ways:

  • it has a static size so you don't know how many periods of history it has (required for UI).
  • it requires filling with a single value (0 isn't practical when you need to find a min and max, since 0 could be a normal value and thus can't be used to identify empty values)
  • it uses a vector instead of array despite having a compile-time constant capacity available
  • it's implementation deviates from the industry standard circular buffer or ring buffer

For these reasons, it is now based on Spartans RingBuffer (#575 )

@wvpm wvpm enabled auto-merge October 16, 2025 13:47
@wvpm wvpm added enhancement New feature or request topic:core labels Oct 16, 2025
@wvpm wvpm added this to the 0.9.0 milestone Oct 16, 2025
@wvpm wvpm merged commit 6b5a60f into master Oct 16, 2025
16 checks passed
@Spartan322 Spartan322 deleted the circular_buffer_instead_of_valuehistory branch October 16, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request topic:core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants