Skip to content

Conversation

@xinitrcn1
Copy link

@xinitrcn1 xinitrcn1 commented Oct 31, 2025

  • thread_local not recommended, stack was preferred
  • Cleans up the loop logic by chaining else/if (no codegen change, just a stylistic choice)
  • Stylistic choice of making the loop more clearly bounded

@Spartan322
Copy link
Member

Could you squash this PR and mention in the commit and PR description about cleaning up the loop?

@xinitrcn1
Copy link
Author

Done.

@Spartan322 Spartan322 added enhancement New feature or request topic:codestyle labels Oct 31, 2025
@Spartan322
Copy link
Member

Spartan322 commented Oct 31, 2025

You'll need to run pre-commit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request topic:codestyle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants