Add clang-format to pre-commit #448
Conversation
Spartan322
force-pushed
the
add/formatting
branch
from
f5cf735 to
0f6f763
Compare
Spartan322
force-pushed
the
add/formatting
branch
4 times, most recently
from
cb4bca4 to
51e9ede
Compare
Spartan322
added
the
salvageable
Spartan322
force-pushed
the
add/formatting
branch
from
51e9ede to
5e55672
Compare
Spartan322
added
topic:codestyle
and removed
salvageable
Spartan322
force-pushed
the
add/formatting
branch
from
5e55672 to
adfc0ba
Compare
| * and so can update it without creating and setting a new image, or not. */ | ||
| bool can_update = state_image.is_valid() && state_image->get_size() == region.get_size() | ||
| && state_image->get_format() == source_image->get_format(); | ||
| * and so can update it without creating and setting a new image, or not. */ |
There was a problem hiding this comment.
Keep operators at the start of a line.
That's way easier to read than at the end of a line.
In the current version it's clearly a && b.
In your proposed version b is just floating there without context.
wvpm
left a comment
wvpm
left a comment
There was a problem hiding this comment.
See comments.
I approve of the snake_case and import changes.
The rest is either worse or as good/bad as before.
Examples of regression include:
- ternary operator formatting
var =with nothing behind it- operators at the end of line
Spartan322
force-pushed
the
add/formatting
branch
2 times, most recently
from
957297c to
cbb44f6
Compare
Add SConstruct and SCsub to ruff/ruff-format pre-commit Standardize header consistency: dependency headers should include with `<...>` local headers should include with `"..."` Standardize GDCLASS terminated with a semicolon Replace camelCase variable names with snake_case
Spartan322
force-pushed
the
add/formatting
branch
from
cbb44f6 to
31aed9a
Compare
| progress_texture = Utilities::make_solid_colour_texture( | ||
| progress_colour, progress_bar->get_size().x, progress_bar->get_size().y | ||
| ); | ||
| progress_texture = |
There was a problem hiding this comment.
(copied)
This line break doesn't make sense.
var = should never be a thing.
Always keep something after the =.
The current/old version is better.
| range_limit_max_rect.position[axis] = slider_start | ||
| + slider_distance * _value_to_ratio(upper_range_limit.value_or(step_count)) | ||
| + slider_rect.size[axis] / 2.0f; | ||
| range_limit_max_rect.position[axis] = slider_start + |
There was a problem hiding this comment.
Keep operators at the start of a line.
That's way easier to read than at the end of a line.
In the current version it's clearly a + b + c.
In your proposed version b is just floating there without context.
| min_value = gui_scrollbar->get_min_value(), | ||
| step_size = gui_scrollbar->get_step_size() | ||
| ](const int32_t val)->int32_t { | ||
| auto adjust_for_min_and_step_size // |
There was a problem hiding this comment.
Starting a line with = looks awful.
The current/old version is good.
2 participants
Add SConstruct and SCsub to ruff/ruff-format pre-commit
Standardize header consistency:
<...>"..."Standardize GDCLASS terminated with a semicolon
Replace camelCase variable names with snake_case