several quality-of-life improvements #293
Conversation
| except: | ||
| return None | ||
|
|
||
| def _queryGaia(ID=None,coords=None, radius = 20): |
There was a problem hiding this comment.
Can you check that queryGaia still works? I think there is something with them changing permissions.
Also if this is adding a new module you'll need to update the docs accordingly.
There was a problem hiding this comment.
works for me out of the box with a fresh env. I'll write up some docs.
|
|
||
| # The inclination prior is a sine truncated between 0, and pi/2. | ||
| self.priors['inc'] = dist.truncsine() | ||
| self.priors['inc'] = dist.truncsine() |
There was a problem hiding this comment.
I think for changing the order of things here you'll need to check that it doesn't influence the sampling.
I remember having problems with that at some point, where I thought using dictionaries should have solved this, but apparently it didn't.
Just so we aren't sampling nurot_e when we think it's something else like eps_g.
| raise ValueError(f'Model {model} is invalid. Please use either MS, SG or RGB.') | ||
|
|
||
| def runl1model(self, progress=True, dynamic=False, minSamples=5000, sampler_kwargs={}, logl_kwargs={}, **kwargs): | ||
| ''' |
There was a problem hiding this comment.
Need to use " " " instead of ' ' '.
| self.Fpp(num_g, nu_p, nu_g, self.obs['dnu'][0], DPi1), lmbda=lmbda) | ||
| return a, b | ||
|
|
||
| num_p, num_g = jax.lax.fori_loop(0, self.rootiter, _body, (nu_p, nu_g)) |
There was a problem hiding this comment.
Does this improve the compile-time?
We of course also need to verify that results don't change.
2 participants
Uh oh!
There was an error while loading. Please reload this page.