-
-
Notifications
You must be signed in to change notification settings - Fork 12
Insert date while creating a checkbox #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ganskef
wants to merge
5
commits into
PKief:main
Choose a base branch
from
ganskef:17-creation-date
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
40f1351
Specification test with begin (#17)
ganskef 2092e40
Create Checkbox with date inserted (#17)
ganskef c97257e
Avoid multiply creation dates (#17)
ganskef 1699007
Fix: existing bullet point causes duplicates (#17)
ganskef 9440347
Merge branch 'main' into 17-creation-date
PKief File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,28 +1,29 @@ | ||||||
| import * as vscode from 'vscode'; | ||||||
|
|
||||||
| /** | ||||||
| * Helper function to set all settings to default values before each test | ||||||
| */ | ||||||
| export const setSettingsToDefault = async () => { | ||||||
| const extensionName = 'markdown-checkbox'; | ||||||
| const defaultSettings = { | ||||||
| checkmark: 'X', | ||||||
| languages: ['markdown'], | ||||||
| withBulletPoint: true, | ||||||
| typeOfBulletPoint: '*', | ||||||
| strikeThroughWhenChecked: true, | ||||||
| italicWhenChecked: true, | ||||||
| dateWhenChecked: true, | ||||||
| showStatusBarItem: true, | ||||||
| dateFormat: 'YYYY-MM-DD', | ||||||
| dateTemplate: '[{date}]', | ||||||
| quickPickEscBehavior: 'doNothing', | ||||||
| }; | ||||||
| await Promise.all( | ||||||
| Object.entries(defaultSettings).map(async ([key, value]) => { | ||||||
| return await vscode.workspace | ||||||
| .getConfiguration(extensionName) | ||||||
| .update(key, value); | ||||||
| }) | ||||||
| ); | ||||||
| }; | ||||||
| import * as vscode from 'vscode'; | ||||||
|
|
||||||
| /** | ||||||
| * Helper function to set all settings to default values before each test | ||||||
| */ | ||||||
| export const setSettingsToDefault = async () => { | ||||||
| const extensionName = 'markdown-checkbox'; | ||||||
| const defaultSettings = { | ||||||
| checkmark: 'X', | ||||||
| languages: ['markdown'], | ||||||
| withBulletPoint: true, | ||||||
| typeOfBulletPoint: '*', | ||||||
| strikeThroughWhenChecked: true, | ||||||
| italicWhenChecked: true, | ||||||
| dateWhenChecked: true, | ||||||
| showStatusBarItem: true, | ||||||
| dateFormat: 'YYYY-MM-DD', | ||||||
| dateTemplate: '[{date}]', | ||||||
| quickPickEscBehavior: 'doNothing', | ||||||
| dateWhenCreated: false, | ||||||
|
||||||
| dateWhenCreated: false, | |
| dateWhenCreated: true, |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded regex pattern
/^(?:[+*-]\s)?\d{4}-\d{2}-\d{2} /assumes ISO date format, but the code ignores thedateFormatconfiguration. This creates inconsistency between date insertion and detection logic, potentially causing issues if users have different date formats configured.