Ruby refresher done #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/questions.rb
Outdated
| # add all the keys and all the values together, e.g. | ||
| # {1 => 1, 2 => 2} becomes 6 | ||
| def add_together_keys_and_values(hash) | ||
| hash.flatten.inject{ |sum, ele| sum += ele } |
lib/questions.rb
Outdated
| hash_count[word.length] ||= 0 | ||
| hash_count[word.length] += 1 | ||
| end | ||
| return hash_count |
lib/questions.rb
Outdated
| # the list of bank holidays is here: | ||
| # https://www.gov.uk/bank-holidays | ||
| def is_a_2014_bank_holiday?(date) | ||
| bank_holidays_2014 = [Time.new(2014, 1, 1), Time.new(2014, 4, 18), Time.new(2014, 1, 21), Time.new(2014, 5, 5), Time.new(2014, 8, 25), Time.new(2014, 12, 25), Time.new(2014, 12, 26)] |
lib/questions.rb
Outdated
| elsif i == 1 | ||
| puts "1 bottle of beer on the wall, 1 bottle of beer.\nTake one down and pass it around, no more bottles of beer on the wall.\n\n" | ||
| else | ||
| puts "#{i} bottles of beer on the wall, #{i} bottles of beer.\nTake one down and pass it around, #{i - 1} bottles of beer on the wall.\n\n" |
lib/questions.rb
Outdated
| # 'The Lion the Witch and the Wardrobe' | ||
| def titleize_a_string(string) | ||
| string.capitalize.split(' ').each do |ele| | ||
| ele.capitalize! unless ['a', 'and', 'the'].index(ele) |
There was a problem hiding this comment.
Use %w or %W for an array of words.
lib/questions.rb
Outdated
| "#{i} bottles of beer.\n"\ | ||
| "Take one down and pass it around, "\ | ||
| "#{i - 1} bottles of beer on the wall.\n\n" | ||
| puts string |
There was a problem hiding this comment.
Move puts string out of the conditional.
lib/questions.rb
Outdated
| def is_a_2014_bank_holiday?(date) | ||
| bank_holidays_2014 = [Time.new(2014, 1, 1), Time.new(2014, 4, 18), | ||
| Time.new(2014, 1, 21), Time.new(2014, 5, 5), Time.new(2014, 8, 25), | ||
| Time.new(2014, 12, 25), Time.new(2014, 12, 26)] |
There was a problem hiding this comment.
Align the elements of an array literal if they span more than one line.
lib/questions.rb
Outdated
| Time.new(2014, 8, 25), | ||
| Time.new(2014, 12, 25), | ||
| Time.new(2014, 12, 26) | ||
| ] |
There was a problem hiding this comment.
Indent the right bracket the same as the start of the line where the left bracket is.
lib/questions.rb
Outdated
| # the list of bank holidays is here: | ||
| # https://www.gov.uk/bank-holidays | ||
| def is_a_2014_bank_holiday?(date) | ||
| bank_holidays_2014 = [ |
There was a problem hiding this comment.
Unnecessary spacing detected.
Operator = should be surrounded by a single space.
|
au moins c'est utile à produire du code plus performant... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.