Skip to content

Conversation

@caspiano
Copy link
Contributor

@caspiano caspiano commented Mar 15, 2022

Supersedes #49
Closes #97

@caspiano caspiano added focus: devops Focus on DevOps/Infra type: refactor labels Mar 15, 2022
@caspiano caspiano requested review from viv-4 and w-le March 15, 2022 00:35
@caspiano caspiano self-assigned this Mar 15, 2022
@w-le
Copy link
Contributor

w-le commented Mar 15, 2022

Lgtm though any reason why we are downgrading elastic to 7.10.2 on line 41 of .env?
If not then I'll change that back to 7.16.2

@caspiano
Copy link
Contributor Author

@w-le Problem was blacktop's logstash being a bit behind.
If we can find an alpine based image that's up to date for logstash, I'll update it

@w-le
Copy link
Contributor

w-le commented Mar 15, 2022

Cool noted
All lgtm

Copy link
Contributor

@w-le w-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks!

@caspiano caspiano requested a review from w-le March 15, 2022 05:08
Copy link
Contributor

@w-le w-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agree with these changes and the new default to disable analytics

@caspiano caspiano merged commit 150646d into master Mar 15, 2022
@caspiano caspiano deleted the feat/optional-analytics branch March 15, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

focus: devops Focus on DevOps/Infra type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow some services to be disabled by the end user as part of the installation

4 participants