Первая версия программы #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indira1919
reviewed
Nov 7, 2023
Comment on lines
+27
to
+39
| System.out.println("Введите сумму вклада в рублях:"); | ||
| depositAmount = scanner.nextInt(); | ||
| System.out.println("Введите срок вклада в годах:"); | ||
| depositPeriod = scanner.nextInt(); | ||
| System.out.println("Выберите тип вклада, 1 - вклад с обычным процентом, 2 - вклад с капитализацией:"); | ||
| command = scanner.nextInt(); | ||
| if (command == 1) { | ||
| amountWithPercents = calculateSimplePercent(depositAmount, yearRate, depositPeriod); | ||
| } else if (command == 2) { | ||
| amountWithPercents = calculateComplexPercent(depositAmount, yearRate, depositPeriod); | ||
| } | ||
| System.out.print("Результат вклада: " + depositAmount + " за " + depositPeriod); | ||
| System.out.print(" лет превратятся в " + amountWithPercents); |
There was a problem hiding this comment.
С 27 по 39 желательно выделить операции в отдельные логические блоки, иначе текст сливается и глаз хуже цепляется за отдельные элементы при первом прочтении. В данном случае это небольшой метод, но в достаточно сложных методах и если ты возвращаешься к этим методами спустя долгое время (> пол года) будет сложно читать и добавлять новый функционал в этот метод
Author
There was a problem hiding this comment.
Спасибо за замечание, я исправлю)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.