hoodi deployment #120
Open
hoodi deployment #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
eladiosch
reviewed
Jul 23, 2025
| // https://hoodi.etherscan.io/address/0xcfc84cED34265A021C2652292dDe48c64A716e47 | ||
| return 0xcfc84cED34265A021C2652292dDe48c64A716e47; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why isn't there a Timelock contract in this chain?
eladiosch
reviewed
Jul 23, 2025
| return 0xc7cc160b58F8Bb0baC94b80847E2CF2800565C50; | ||
| } else if (block.chainid == hoodi) { | ||
| // No Lido withdrawal queue on Hoodi testnet, using stETH address as fallback | ||
| return 0xA1e64F52b83C9D0c2b2B5b7e16c8D5b9B3d8e4EA; |
There was a problem hiding this comment.
Is stETH contract interchangeable with LidoWithdrawalQueue?
There was a problem hiding this comment.
Also that address is a EOA. stETH address is 0x3508A952176b3c15387C97BE809eaffB1982176a
eladiosch
reviewed
Jul 23, 2025
| // https://holesky.etherscan.io/address/0xB028194785178a94Fe608994A4d5AD84c285A640 | ||
| return 0xB028194785178a94Fe608994A4d5AD84c285A640; | ||
| } else if (block.chainid == hoodi) { | ||
| // Deployed ValidatorTicket address |
There was a problem hiding this comment.
Add explorer link for consistency:
https://hoodi.etherscan.io/address/0x6E0225679209459a355297A43B61cAFbC1Ca8d46
eladiosch
reviewed
Jul 23, 2025
| return address(0); // TODO | ||
| } else if (block.chainid == hoodi) { | ||
| // https://hoodi.etherscan.io/address/0x7aD345dC8583015f31E8f03CAE9cA09706514349 | ||
| return 0x7aD345dC8583015f31E8f03CAE9cA09706514349; |
eladiosch
requested changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.