Cancel withdrawal #131
Open
Cancel withdrawal #131
+554
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
eladiosch
reviewed
Sep 24, 2025
| require(batchIndex > $.finalizedWithdrawalBatch, WithdrawalAlreadyFinalized()); | ||
|
|
||
| uint256 pufETHAmount = withdrawal.pufETHAmount; | ||
| address recipient = withdrawal.recipient; |
There was a problem hiding this comment.
Since we're using withdrawal.recipient in some checks before this line, we could declare this first and use the local variable instead
eladiosch
reviewed
Sep 24, 2025
| Withdrawal memory withdrawal = $.withdrawals[withdrawalIdx]; | ||
|
|
||
| // Check if withdrawal has already been completed (recipient is set to address(0) when completed) | ||
| require(withdrawal.recipient != address(0), WithdrawalAlreadyCompleted()); |
There was a problem hiding this comment.
Is this necessary since we're already checking if the withdrawal is finalized?
There was a problem hiding this comment.
Disregard comment. This is useful to prevent cancelling the same withdrawal twice
|
The actual coverage of the contract is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.