Skip to content

fix: filter out unbounded rhs in lp-polars #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: filter out unbounded rhs in lp-polars #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions linopy/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,17 +361,26 @@ def constraints_to_file(
if df.height == 0:
continue

# Ensure each constraint has both coefficient and RHS terms
# <= + inf and >= - inf are unbounded and skipped
rhs_unbounded = pl.col("rhs").is_infinite() & (
pl.when(pl.col("sign") == "<=")
.then(pl.col("rhs") >= 0)
.when(pl.col("sign") == "<=")
.then(pl.col("rhs") <= 0)
.otherwise(pl.lit(False))
)

# Ensure each constraint has both coefficient terms and a valid rhs
analysis = df.group_by("labels").agg(
[
pl.col("coeffs").is_not_null().sum().alias("coeff_rows"),
pl.col("sign").is_not_null().sum().alias("rhs_rows"),
(pl.col("rhs").is_not_null() & ~rhs_unbounded)
.any()
.alias("has_rhs"),
]
)

valid = analysis.filter(
(pl.col("coeff_rows") > 0) & (pl.col("rhs_rows") > 0)
)
valid = analysis.filter((pl.col("coeff_rows") > 0) & pl.col("has_rhs"))

if valid.height == 0:
continue
Expand Down
Loading