Skip to content

Conversation

subscorp
Copy link

No description provided.

Copy link
Contributor

@PureDreamer PureDreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as always, best code in the course!!

@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #299 (5fd6929) into develop (f04a433) will increase coverage by 1.83%.
The diff coverage is 98.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    94.42%   96.25%   +1.83%     
===========================================
  Files           91       92       +1     
  Lines         4236     4278      +42     
===========================================
+ Hits          4000     4118     +118     
+ Misses         236      160      -76     
Impacted Files Coverage Δ
app/main.py 94.82% <92.30%> (-1.01%) ⬇️
app/database/models.py 97.51% <100.00%> (+0.04%) ⬆️
app/internal/daily_quotes.py 100.00% <100.00%> (ø)
app/internal/event.py 96.62% <100.00%> (ø)
app/routers/favorite_quotes.py 100.00% <100.00%> (ø)
app/routers/audio.py 100.00% <0.00%> (+56.09%) ⬆️
app/internal/audio.py 100.00% <0.00%> (+71.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04a433...5fd6929. Read the comment docs.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants