Feature/cursor

[subscorp]

No description provided.

[codecov-io]

Codecov Report

Merging #307 (b01c459) into develop (8d83f8b) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
+ Coverage    94.39%   94.65%   +0.25%     
===========================================
  Files           89       87       -2     
  Lines         4156     4038     -118     
===========================================
- Hits          3923     3822     -101     
+ Misses         233      216      -17     

Impacted Files	Coverage Δ
app/main.py	95.23% <ø> (-0.60%)	⬇️
app/dependencies.py	87.87% <100.00%> (+0.37%)	⬆️
app/internal/cursor.py	100.00% <100.00%> (ø)
app/routers/cursor.py	100.00% <100.00%> (ø)
app/internal/event.py	95.71% <0.00%> (-0.92%)	⬇️
app/database/models.py	97.18% <0.00%> (-0.19%)	⬇️
app/routers/google_connect.py	100.00% <0.00%> (ø)
app/internal/features_index.py
app/resources/countries.py
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d83f8b...0fdce31. Read the comment docs.

[Gonzom]

I'm not sure we need a route for every setting option. This should probably be routers.setting.py and the calls should be:

• @router.get("/settings/cursor")
• @router.post("/settings/cursor")
• @router.get("/{user_id}/cursor")

[subscorp]

Did you mean that there shouldn't be a [setting_type].py file for each setting type?
So if I have Audio Settings and Cursor Settings, both of them should be in routers.setting.py, but the @router functions should stay the same, only in this new file instead of the old one?
Thanks for your feedback!

[yammesicka]

Great job! Please have a look at my insights :)