Make text sizes and colors overrideable #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apksherlock
reviewed
May 10, 2021
Contributor
apksherlock
left a comment
apksherlock
left a comment
There was a problem hiding this comment.
Hello. Thanks for this PR and sorry for the late reply
|
|
||
| @ColorInt | ||
| var defaultColor: Int = ContextCompat.getColor(context, R.color.survey_text) | ||
| var defaultColor: Int = ContextCompat.getColor(context, R.color.question_text) |
Contributor
There was a problem hiding this comment.
Why changing the name?
Author
There was a problem hiding this comment.
The idea was to have "survey_text" as default like before but at the same time be able to override specific element colors.
Have a look over at https://github.com/quickbirdstudios/SurveyKit/blob/2e8d00ee659b347f19f20ece226b47801f055349/survey/src/main/res/values/colors.xml#L23-L30: The default is that all the elements use the color defined in "survey_text" but an app using the SurveyKit library is able to override specific colors.
survey/src/main/java/com.quickbirdstudios.surveykit/backend/views/question_parts/ScalePart.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additions to allow to customize text sizes and font colors