Modify signals available to getsignals on WIN32 #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the signals we need for Windows are actually already defined in os.constants.signals
The following signals are defined on the MoarVM and JS backends.
|
@jstuder-gh sorry I've missed your request for a review back in 2018. I don't use Windows, but as far as I can see, adding the signals to The merge conflict stems from renaming s/perl6/raku/ earlier today (#630). It shouldn't be hard to resolve -- the changes need probably just copied over to the new location |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS:
All the signals we need for Windows are actually already defined in
os.constants.signals
JVM:
Match getsignals JVM with MoarVM/JS backends