forked from Recoded-sana-a-resouces/weather_app_js
-
Notifications
You must be signed in to change notification settings - Fork 7
weatherApp v 1.1 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haval95
wants to merge
49
commits into
Re-Coded-react-bootcamp:master
Choose a base branch
from
haval95:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
weatherApp v 1.1 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut of the Heder folder, so all component folders are in the component folder
add chart
feat: add css code to design the header
feat: add space closes #4
changing the chart values
Feat: add City Temperature component
Feat: Header Component Created
here i have centred the component and also given a light backgound closes: #9
Styling city temperature
header is finished building closes #1
Feat: header Created
I repositioned the chart component closes #3
Style: Styling the chart component
we will mix our styling with react ReactBootstrap closes #19
feat: add React bootstrap
I used to useEffect to fetch data frist to get the country id from the api then based on that id i am fetching the weather. closes #12
Feat: Fetched weather data
splited the error from the data object so i use one hook for both fetch.
each weather will show its relative Icon.
I have added a helper component to help me build the table component, the helper has two functions and one of them is for generating table heading and another for generating table data. I send data as props to these helpers and they return table rows. and I show them in my Week table. closes #10 #11
One week temp table
I re-styled the components using React bootstrap
Chart data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.