Deprecate as_json and array_as_json methods #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ized` and `array_as_serialized`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #64. I did not go with
as_hashbecause it felt a bit vague, andserializeis already an existing class-level method. Instead, I renamedas_jsontoas_serialized. I turnedas_jsonandarray_as_jsoninto wrapper methods so that codebases currently using those two methods won't be broken by this change (until those methods are later removed 😄 ).Update README and added a deprecation note.
We're starting to use
as_jsonin our project, so I thought it would be a great time to go ahead and tackle this refactor. I double-checked that this code change does still work in our app using either theas_jsonmethod or theas_serialized.