Skip to content

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Aug 25, 2025

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Extract datafiles action buttons into a shared, configurable component and remove the legacy dataset-specific implementations

New Features:

  • Introduce a shared ConfigurableActionsModule providing reusable ConfigurableActionsComponent and ConfigurableActionComponent for rendering action buttons

Enhancements:

  • Replace dataset-specific DatafilesActions and DatafilesAction components and templates with the generic configurable actions component
  • Refactor component logic to use optional chaining for file inputs and update input type annotations

Tests:

  • Update specs to reference ConfigurableActionComponent and ConfigurableActionsComponent instead of the old datafiles action components
  • Remove obsolete mocks and commented-out test code

Chores:

  • Add ConfigurableActionsModule to SharedScicatFrontendModule and remove legacy DatafilesAction declarations from DatasetsModule
  • Delete deprecated datafiles-actions component files and SCSS

@martin-trajanovski martin-trajanovski self-assigned this Sep 16, 2025
@martin-trajanovski martin-trajanovski added the DCS DAPHNE Contribution to SciCat label Sep 16, 2025
@cchndl
Copy link

cchndl commented Sep 17, 2025

Hi,

two points I noticed while testing:

  • would it be possible to have a type_json that does not expect a download in return? If not the form is fine on my end.
  • in the batch view the type_json_download fails, because files seems to not be defined.

In general, would it make sense to unify the different methods a little bit? Building the info as an object in a shared way and then transforming it into json/the form etc?

I tested it when the PR was at 3f4de3, so I haven't run the most recent state yet, but as far as I can see, these points didn't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants