Skip to content

Conversation

Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented Oct 2, 2025

Description

update tooltip information for proposal tabs

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Enhancements:

  • Refined tooltip messages for Details, Datasets, Related Proposals, and Logbook tabs on the view proposal page

@Junjiequan Junjiequan requested a review from nitrosx October 2, 2025 09:17
@Junjiequan Junjiequan changed the title fix: update tooltip information for proposal tabs fix: update tooltip information for proposal tabs Oct 2, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider making these tooltip strings translatable (using the translate pipe) to keep localization consistent with the rest of the UI.
  • You might want to add consistent data-cy or other test selectors on each tab label to streamline end-to-end testing across all tabs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making these tooltip strings translatable (using the translate pipe) to keep localization consistent with the rest of the UI.
- You might want to add consistent data-cy or other test selectors on each tab label to streamline end-to-end testing across all tabs.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Junjiequan Junjiequan force-pushed the add-tool-tip-to-proposal-tabs branch 2 times, most recently from 7284730 to 71f2b46 Compare October 7, 2025 14:36
@Junjiequan Junjiequan force-pushed the add-tool-tip-to-proposal-tabs branch from 71f2b46 to d114fb3 Compare October 8, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant