-
Notifications
You must be signed in to change notification settings - Fork 33
feat: ingestor component for datasets #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: ingestor component for datasets #2040
Conversation
…ent (SciCatProject#1673) * fix: optimize condition editing logic in DatasetsFilterSettingsComponent * if user creates duplicated condition, do nothing * add snackbar notification for duplicate condition in DatasetsFilterSettingsComponent * remove unused import * remove panelClass from snackBar * added e2e test for the change
* feat: add the new auth service to prepare for the new sdk * try to fix some ai-bot review suggestions * add the note for the good review suggestion from ai-bot * remove old sdk and adjust types against the new one * fix more types and issues against the new sdk * finalize type error fixes * remove prefix * add the new sdk generation script for local development * start fixing TODOs after newly generated sdk * fixed sdk local generation for linux * update the sdk package version and fix some more types * detect the OS and use the right current directory path * improve types and fix more TODOs * improve types and fix TODOs after backend improvements * finalize TODOs and FIXMEs fixes and type improvements with the new sdk * fix some sourcery-ai comments * fix some of the last TODOs * adapted sdk generation to unix environment * ignore the @SciCatProject that is generated with the sdk * start fixing tests with the new sdk * add needed stub classes and fix some more tests * continue fixing unit tests * try to fix e2e tests and revert some changes that need more attention for now * changes to just run the tests * use latest sdk * update package-lock file * fixing unit tests * fix more unit tests * continue fixing tests * update the sdk * fix last e2e test * fix thumbnail unit tests * revert some change * finalize fixing unit tests * revert the backend image changes after the tests pass * add some improvements in the mocked objects for unit tests based on ai bot suggestion * remove encodeURIComponent in the effects as it seems redundant * fix test files after some changes * try to use mock objects as much as possible * update the sdk version * update package-lock file * update the sdk to latest * BREAKING CHANGE: new sdk release --------- Co-authored-by: martintrajanovski <[email protected]> Co-authored-by: Jay <[email protected]>
…tails dashboard onDestroy
This reverts commit d31fef6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @sofyalaski, your pull request is larger than the review limit of 150000 diff characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @sofyalaski, your pull request is larger than the review limit of 150000 diff characters
Great work putting this together @sofyalaski! |
Description
This is a big PR that introduces two changes.
config.json
file by setting:addDatasetEnabled
)Motivation
At PSI with OpenEM we have been working on a new ingestor backend that will allow data ingestion from sites different from the host of SciCat Catalog. This is represented by Point 1. An addition of the Ingestor backend repo into SciCatProject is planned as well.
Changes:
For point 2:
For point 1:
config.json
changes include this new object:The main option to turn off the component entirely is controlled by the
ingestorEnabled
value. This will redirect call to ingestor to 404. When turned on, the ingestor component is available at/ingestor/
with a link in the hamburger menu.ingestorAutodiscoveryOptions
is an optional argument and constitutes an array of available facilities running ingestor software.facilityBackend
is a reachable backend of the ingestor service.mailDomain
is used to match the email of logged-in user against themailDomain
value as a regular expression and in case of success, automatically connect to the respective backend. A regular expression is used to connect to the email of form "staff.university.org" or similar.description
is optional, but in case of the match withmailDomain
will prefill the creationLocation property in the dataset schemaIngestor component ( when used with the backend ) looks similar to the Point 2 and represents a set of dialogs for SciCat dataset and scientific metadata ingestion, with most of the information prefilled. For this, it interacts with ingestor backend, which does all the hard work such as:
scientificMetadata
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version