Mooncake, LinearSolve integration - 1 #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstitvaAggarwal
changed the title
| include("wrappers.jl") | ||
|
|
||
| import Base: (\), size, getproperty, setproperty!, propertynames, show, | ||
| import Base: size, getproperty, setproperty!, show, |
There was a problem hiding this comment.
I was getting ExplicitImports, Aqua errors in all / Tests - NoPre since the import were not being technically directly used. In the same file, they are used as Base.propertynames etc. so I removed the imports.
There was a problem hiding this comment.
after this we get the errors : https://github.com/SciML/LinearSolve.jl/actions/runs/18461238570/job/52593055519?pr=791. (dont seem PR related)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The current PR handles differentiating when using Mooncake for functions tested in
test/adjoint.jl,solve(). We reuse the currentChainrulesrules defined insrc/adjoint.jl. These rules are now used byZygoteandMooncake.An rrule for
solve!are required, followed by tests forMooncake(relevant to the ones in theEnzyme.jlExtension testfile). I will add this is a subsequent seperate PR.NOTE : Mooncake only works with Julia (lts) as of now, due to how it handles IR changes in different Julia versions
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.