Skip to content

refactor: use @deprecate_binding to deprecate ODESystem #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: use @deprecate_binding to deprecate ODESystem #3815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ModelingToolkit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ $(TYPEDEF)
TODO
"""
abstract type AbstractSystem end
# Solely so that `ODESystem` can be deprecated and still act as a valid type.
# See `deprecations.jl`.
abstract type IntermediateDeprecationSystem <: AbstractSystem end

function independent_variable end

Expand Down
8 changes: 1 addition & 7 deletions src/deprecations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,7 @@ macro mtkbuild(exprs...)
end |> esc
end

const ODESystem = IntermediateDeprecationSystem

function IntermediateDeprecationSystem(args...; kwargs...)
Base.depwarn("`ODESystem(args...; kwargs...)` is deprecated. Use `System(args...; kwargs...) instead`.", :ODESystem)

return System(args...; kwargs...)
end
Base.@deprecate_binding ODESystem System

for T in [:NonlinearSystem, :DiscreteSystem, :ImplicitDiscreteSystem]
@eval @deprecate $T(args...; kwargs...) System(args...; kwargs...)
Expand Down
2 changes: 1 addition & 1 deletion src/systems/system.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ structure.

$(TYPEDFIELDS)
"""
struct System <: IntermediateDeprecationSystem
struct System <: AbstractSystem
"""
$INTERNAL_FIELD_WARNING
A unique integer tag for the system.
Expand Down
Loading