Skip to content

Fix some warnings. #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix some warnings. #1274

wants to merge 2 commits into from

Conversation

Lamothe
Copy link
Contributor

@Lamothe Lamothe commented Oct 5, 2025

No description provided.

martindevans
martindevans requested changes Oct 5, 2025
View reviewed changes
Copy link
Member

@martindevans martindevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks for tackling these! Just that one issue and then we're good to merge.

LLama/LLamaExecutorBase.cs
/// <param name="inferenceParams"></param>
/// <param name="args"></param>
/// <returns></returns>
protected abstract Task<(bool, IReadOnlyList<string>)> PostProcess(IInferenceParams inferenceParams, InferStateArgs args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for anything inheriting from executor base. So it needs to stay async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martindevans martindevans martindevans requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lamothe @martindevans