-
Notifications
You must be signed in to change notification settings - Fork 29
Refactor: Generalize Complexity Score Calculation for Multiple Providers #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
The test are passing on my system. The environment variables will have to be updated for CI / CD |
Before I approve and we merge, can you please provide the exact update that will be needed to make it pass? |
We need to update the secrets for the CI / CD. The secret For users, the credentials should also be stored in the specified format, in the
|
'--provider', | ||
'idt', | ||
'--credentials', | ||
str(test_dir.parent / 'test_secret_idt_credentials.json'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the secrets, but the tests are currently failing because some of the references are still to the old credentials and not the updated credentials.
4f464b6
to
2c40e4c
Compare
2c40e4c
to
8df2b78
Compare
The tests are currently failing due to a mismatch in word casing: This update should resolve the issue. |
This PR refactors the DNA complexity score calculation to be more extensible and support multiple providers beyond IDT. The changes include generalizing function names, updating docstrings to be provider-agnostic, and preparing the script for future modularity improvements.
NOTE: This PR introduces breaking changes.
BREAKING CHANGE
Previous json file format:
New json file format:
The new format stores the credentials as
{ "provider_name": { "key": "value", ... } }
. It also adheres to snake case for all keys.