-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Adds serde_yaml dependency and implement YAML configuration loa… #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the lum_config FileHandler with direct YAML configuration loading using serde_yaml. The change simplifies configuration management by removing a dependency layer and implementing custom YAML file handling logic.
Key changes:
- Removes FileHandler dependency from lum_config and adds serde_yaml dependency
- Implements custom config file loading with automatic directory creation and default config generation
- Adds example YAML configuration file showing the expected format
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/main.rs | Replaces FileHandler with custom YAML config loading logic and adds new error variants |
example-config.yaml | Provides example configuration showing YAML structure and available options |
Cargo.toml | Adds serde_yaml dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I made some recommendations. We should also think about adding yaml support in lum_config upstream instead of implementing it here. But that's up to the future, implementing it here is okay for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3b2aa3a
to
0db9675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds serde_yaml dependency and removes the lum_config FileHandler.