Skip to content

Add missing API annotation, remove confusing log message #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 1.21.6
Choose a base branch
from
Open

Add missing API annotation, remove confusing log message #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6b603b
Mark `UpdateChecker#checkForUpdates` as `@Nullable`
LostLuma Jul 28, 2025
c67a9db
Remove update info log when a mod update has no update
LostLuma Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/terraformersmc/modmenu/api/UpdateChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.terraformersmc.modmenu.api;

import org.jetbrains.annotations.Nullable;

public interface UpdateChecker {
/**
* Gets called when ModMenu is checking for updates.
Expand All @@ -9,5 +11,5 @@ public interface UpdateChecker {
*
* @return The update info
*/
UpdateInfo checkForUpdates();
@Nullable UpdateInfo checkForUpdates();
}
8 changes: 3 additions & 5 deletions src/main/java/com/terraformersmc/modmenu/util/UpdateCheckerUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,11 @@ private static void checkForUpdates0() {
Thread.currentThread().setName("ModMenu/Update Checker/%s".formatted(mod.getName()));

var update = updateChecker.checkForUpdates();
mod.setUpdateInfo(update);

if (update == null) {
return;
if (update != null && update.isUpdateAvailable()) {
LOGGER.info("Update available for '{}@{}'", mod.getId(), mod.getVersion());
}

mod.setUpdateInfo(update);
LOGGER.info("Update available for '{}@{}'", mod.getId(), mod.getVersion());
});
}
}
Expand Down