added powersort in sorts/power_sort.py #13219
Conversation
…ing links to the Wikipedia page and the original paper by Munro and Wild.
for more information, see https://pre-commit.ci
…ted import statements, removed unnecessary whitespace, and enhanced comments for better readability. Adjusted key function handling for reverse sorting and ensured proper handling of numeric and non-numeric types.
|
ruff issues fixed |
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/power_sort.py
Outdated
| return start + 1 | ||
|
|
||
|
|
||
| key_func = key if key else lambda x: x |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
sorts/power_sort.py
Outdated
| return run_end | ||
|
|
||
|
|
||
| def _node_power(n: int, b1: int, n1: int, b2: int, n2: int) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
sorts/power_sort.py
Outdated
| >>> arr | ||
| [1, 2, 3, 5, 6, 7] | ||
| """ | ||
| key_func = key if key else lambda x: x |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
sorts/power_sort.py
Outdated
| if key: | ||
| original_key = key | ||
|
|
||
| def reverse_key(x): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/power_sort.py, please provide doctest for the function reverse_key
Please provide return type hint for the function: reverse_key. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
Please provide type hint for the parameter: x
sorts/power_sort.py
Outdated
| needs_final_reverse = True | ||
| else: | ||
|
|
||
| def reverse_cmp(x): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/power_sort.py, please provide doctest for the function reverse_cmp
Please provide return type hint for the function: reverse_cmp. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
Please provide type hint for the parameter: x
for more information, see https://pre-commit.ci
…rameter names for better understanding, improved comments for key functions, and ensured consistent handling of total length in calculations. This improves readability and maintainability of the code.
algorithms-keeper
bot
removed
require descriptive names
for more information, see https://pre-commit.ci
…ility. Adjusted whitespace and line breaks in function definitions and comments to enhance clarity without altering functionality.
|
mhmm?? |
|
@cclauss hello? |
Describe your change:
Checklist: