Skip to content

Fix compiler warnings and the bugs they point to #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix compiler warnings and the bugs they point to #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
309978f
BinaryStream: fix segmentation fault when working with std::deque
Feb 20, 2023
4733154
BinaryStream: fix compiler warnings on using '*' in boolean context
Feb 20, 2023
3d43ef9
BinaryStream: generalize the API and make it work with const references
Feb 22, 2023
baad6f3
BinaryStream: avoid redundant tests for the mode
Feb 22, 2023
bfe0f2f
src/Store/BStore.cpp: fix compiler warning on "/*" within comment
Feb 22, 2023
267fdab
SerialisableObject: add virtual destructor
Feb 22, 2023
3793f9e
BinaryStream::(de-)serialise(std::string& rhs): revert to using &rhs[…
Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/Store/BStore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ bool BStore::Serialise(BinaryStream &bs){ // do return properly
bs & output;
bs & m_lookup;
GetEntry(0);
/*
#if 0
save;

if(bs.m_write){
Expand All @@ -761,9 +761,9 @@ bool BStore::Serialise(BinaryStream &bs){ // do return properly
close
open
}
*/
#endif

/*
#if 0
bs & m_lookup;


Expand All @@ -789,7 +789,7 @@ bool BStore::Serialise(BinaryStream &bs){ // do return properly

if(!GetHeader()) return false;
if(!GetEntry(0)) return false;
*/
#endif



Expand All @@ -801,7 +801,7 @@ bool BStore::Serialise(BinaryStream &bs){ // do return properly
/////


/* // uncomment here to start
#if 0 // uncomment here to start
//writing
if(bs.m_write){
if(not ram){
Expand Down Expand Up @@ -856,7 +856,7 @@ bool BStore::Serialise(BinaryStream &bs){ // do return properly
}


/*
#if 0
//std::cout<<"p1"<<std::endl;
if(!(bs & m_variables)) return false;
//std::cout<<"p2"<<std::endl;
Expand All @@ -872,7 +872,8 @@ bool BStore::Serialise(BinaryStream &bs){ // do return properly
//std::cout<<"p6"<<std::endl;
if(!(bs & m_lookup)) return false;
//std::cout<<"p7"<<std::endl;
*/
#endif
#endif

return true;

Expand Down
Loading