Skip to content

Conversation

thomasloux
Copy link
Contributor

@thomasloux thomasloux commented Sep 29, 2025

Summary

Add support for batch systems for NVT Nosé Hoover #262
Add tests: batched systems, identical results for batched systems and independent single run (with same initial state, most importantly the momenta).

I've also carefully checked that the behaviour is the same as the previous non batched implementation.

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
  • Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.
  • I have read and agree to the Contributor's Certification in CONTRIBUTING.md.

We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run pip install pre-commit && pre-commit install to install the hooks which will check your code before each commit.

@thomasloux
Copy link
Contributor Author

thomasloux commented Sep 29, 2025

@orionarcher You can review, normally there are not big changes ! Let me know if you want me to modify some parts

@abhijeetgangan
Copy link
Collaborator

@thomasloux Thanks for the PR. I will take a look at it once we merge the API changes.

Copy link
Collaborator

@orionarcher orionarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @thomasloux! I am not enough of a physicist to validate the integration logic but the code and API both look clean aside from a couple nits.

@thomasloux
Copy link
Contributor Author

By the way, I probably broke the npt nosé hoover. So I need to adapt in the same way the integrator.

@thomasloux
Copy link
Contributor Author

Hey @abhijeetgangan, I've merged the API change. Tests are passing. Note: we may want to add a test for we hardcode the value of a simulation with all integrators that we have to check that we don't change the results among versions.

@abhijeetgangan
Copy link
Collaborator

Thanks a lot @thomasloux . I will go through it this weekend. For the tests; I agree that we need another check other than the stability checks. We could have numerical values of MD averages. I would also like to have integration tests comparing the values with LAMMPS. Could be a script that runs in CI with bunch of assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants