-
Notifications
You must be signed in to change notification settings - Fork 46
Feature/batched nvt nose hoover #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/batched nvt nose hoover #265
Conversation
@orionarcher You can review, normally there are not big changes ! Let me know if you want me to modify some parts |
@thomasloux Thanks for the PR. I will take a look at it once we merge the API changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @thomasloux! I am not enough of a physicist to validate the integration logic but the code and API both look clean aside from a couple nits.
By the way, I probably broke the npt nosé hoover. So I need to adapt in the same way the integrator. |
…thomasloux/torch-sim into feature/batched-nvt-nose-hoover
Hey @abhijeetgangan, I've merged the API change. Tests are passing. Note: we may want to add a test for we hardcode the value of a simulation with all integrators that we have to check that we don't change the results among versions. |
Thanks a lot @thomasloux . I will go through it this weekend. For the tests; I agree that we need another check other than the stability checks. We could have numerical values of MD averages. I would also like to have integration tests comparing the values with LAMMPS. Could be a script that runs in CI with bunch of assertions. |
Summary
Add support for batch systems for NVT Nosé Hoover #262
Add tests: batched systems, identical results for batched systems and independent single run (with same initial state, most importantly the momenta).
I've also carefully checked that the behaviour is the same as the previous non batched implementation.
Checklist
Before a pull request can be merged, the following items must be checked:
We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run
pip install pre-commit && pre-commit install
to install the hooks which will check your code before each commit.