Skip to content

Conversation

niklashoelter
Copy link

Summary

Bug fix proposal for #276 - changed determine_max_batch_size() loop to increase batch sizes in a way that it compares the number of atoms in the batch to max_atoms parameter.

Also, passed the max_atoms_to_try parameter to the _chunked_apply() function within the optimize() function.

Tests also adapted for the "new"/fixed logic.

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
  • Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.

We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run pip install pre-commit && pre-commit install to install the hooks which will check your code before each commit.

Copy link
Collaborator

@orionarcher orionarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix! Just fix the lint and should be good to go (recommend running pre-commit locally)

Ignore the failing models tests for now, that's not due to any changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants