-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Feat/hardhat tests #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EthanOK
wants to merge
255
commits into
Uniswap:feat/foundry-tests
Choose a base branch
from
EthanOK:feat/hardhat-tests
base: feat/foundry-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/hardhat tests #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an apparent bug in the ERC20-ERC20 exchange contract, in which two methods use the equality operator == instead of the assignment operator =.
contracts: drop swapOutput
This refactors the ERC20-ERC20 contract to split swapInput into two public functions, with the shared logic in a single private function. This reduces the amount of branching, and is likely to make further changes (such as caching reserve balances and recording accumulator values for the oracle) easier.
contracts: track reserves in ERC20-ERC20 exchange and remove transferFrom
Prepare for deploying the contracts and build artifacts to npmjs
* Widen the pragma This reverts commit 528056e
This reverts commit 6a67b82.
* Create CITATION.cff I want to cite this Github repository in some research papers I am writing. A `CITATION.cff` auto generates citations for anyone who may want to reference this repository in their work. See the (docs)[https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files]. I have drafted this to include the authors of the repository if you desire any changes, please make them. Thank you. * Update CITATION.cff Co-authored-by: Noah Zinsmeister <[email protected]>
feat: add stale config
v1.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add hardhat test