Skip to content

fix: remove infinite while loop and added error handling for retrieve_cert() #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: remove infinite while loop and added error handling for retrieve_cert() #122

wants to merge 3 commits into from

Conversation

mowdash
Copy link

@mowdash mowdash commented Dec 2, 2022

Working with TPP, trying to retrieve a non-existing cert would result in an infinite while loop with the following error message...

ERROR:root:Unknown error format: {'Error': 'Certificate test does not exist.'}
ERROR:root:Unknown error format: {'Error': 'Certificate test does not exist.'}
ERROR:root:Unknown error format: {'Error': 'Certificate test does not exist.'}

Instead we now log the error once and raise a RetrieveCertificateNotFound error.

@mowdash mowdash changed the title fix: raise error if cert not found instead of continuing within infinite while loop fix: remove infinite while loop and added error handling for retrieve_cert() Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvelaVenafi rvelaVenafi Awaiting requested review from rvelaVenafi rvelaVenafi is a code owner

@marcos-albornoz marcos-albornoz Awaiting requested review from marcos-albornoz marcos-albornoz is a code owner

@luispresuelVenafi luispresuelVenafi Awaiting requested review from luispresuelVenafi luispresuelVenafi is a code owner

@EduardoVV EduardoVV Awaiting requested review from EduardoVV EduardoVV is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mowdash