fix: prevent app crash when wallet locks during Supply modal interaction #2574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aave#2382 - Implements comprehensive wallet disconnection handling Changes: - Fix UserAuthenticated component to handle disconnection gracefully - Remove invariant assertion that caused crashes - Show "Connect Wallet" UI when user becomes undefined - Add WalletGuard provider for global disconnection monitoring - Monitors wallet connection state via wagmi - Automatically closes all modals on disconnection - Prevents stale transaction state - Enhance SupplyModal with disconnection guards - Check wallet connection before rendering modal content - Show appropriate "Connect Wallet" message when disconnected - Add TransactionErrorBoundary for additional safety - Catches errors in transaction modals - Provides recovery mechanism for wallet-related errors - Prevents crashes from propagating to app level This fix ensures the app handles wallet disconnection events (MetaMask lock, Rabby lock, Ambire lock, etc.) gracefully without crashing, improving overall UX reliability and preventing data loss during wallet disconnection events.
|
@mmarfinetz is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @sendra @foodaka @sakulstra @bpierre @grothem! This PR fixes the critical wallet lock crash issue #2382 that affects users when their wallet extension (MetaMask/Rabby/Ambire) locks while modals are open. The fix implements:
This prevents the app from crashing and improves UX reliability. Would appreciate a review when you have a chance. Happy to make any adjustments needed! |
…rd and TransactionErrorBoundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2382 - Prevents app crash when wallet is locked while Supply modal is open
Changes
UserAuthenticatedcomponent to handle disconnection gracefullyWalletGuardprovider to monitor wallet disconnection eventsSupplyModalwith connection state guardsTransactionErrorBoundaryfor additional safety_app.page.tsxwith proper hierarchyProblem
When users lock their wallet extension (MetaMask/Rabby/Ambire) while the Supply modal is open, the app crashes with:
Solution
Implemented a two-part defensive strategy:
Testing
Impact
Screenshots
N/A - Fix is for preventing crashes, behavior change is the absence of errors
Checklist