Skip to content

fix: fix Horizon banner redirection when navigating from the sGHO page #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix Horizon banner redirection when navigating from the sGHO page #2641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
621d105
fix: fix Horizon banner redirection when navigating from the sGHO page
AGMASO Sep 16, 2025
bcb4301
chore: clean code
AGMASO Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pages/sgho.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { AaveV3Ethereum } from '@bgd-labs/aave-address-book';
import { Trans } from '@lingui/macro';
import { Box, Paper, Typography, useMediaQuery, useTheme } from '@mui/material';
import dynamic from 'next/dynamic';
import { useRouter } from 'next/router';
import { useEffect } from 'react';
import { ContentContainer } from 'src/components/ContentContainer';
import { ConnectWalletButton } from 'src/components/WalletConnection/ConnectWalletButton';
Expand Down Expand Up @@ -49,14 +50,15 @@ export default function SavingsGho() {
const { data: stakeUserResult } = useUserStakeUiData(currentMarketData);

const { data: stakeGeneralResult } = useGeneralStakeUiData(currentMarketData);

// Automatically switch to mainnet if not already on mainnet
const router = useRouter();
// Automatically switch to mainnet if not already on mainnet when entering the sGHO page
// since sGHO only exists on Ethereum mainnet
// NOTE: Having currentMarket as a dependency in useEffect causes conflicts with the Horizon Banner interaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we click the link in the banner to go to the Horizon Markets page, the useEffect detects that currentMarket has changed and re-renders the component, preventing us from reaching the desired page. The solution is to remove currentMarket from the useEffect dependency array.

useEffect(() => {
if (currentMarket !== CustomMarket.proto_mainnet_v3) {
if (router.pathname === '/sgho' && currentMarket !== CustomMarket.proto_mainnet_v3) {
setCurrentMarket(CustomMarket.proto_mainnet_v3);
}
}, [currentMarket, setCurrentMarket]);
}, [router.pathname, setCurrentMarket]);

useEffect(() => {
trackEvent('Page Viewed', {
Expand Down
Loading