feat: improve banner logic #2693

foodaka · 2025-10-02T09:24:55Z

General Changes

Improves logic for handling which banner is shown(before main net would briefly show and then the intended banner)
Adds banner for arb limit orders

Developer Notes

Add any notes here that may be helpful for reviewers.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

End-to-end tests are passing without any errors
Code changes do not significantly increase the application bundle size
If there are new 3rd-party packages, they do not introduce potential security threats
If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

vercel · 2025-10-02T09:25:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
interface	Error			Oct 3, 2025 3:56pm

Copilot

Pull Request Overview

This PR improves the banner display logic to prevent brief flashing of incorrect banners and adds support for Arbitrum limit orders campaigns. The changes ensure that only the intended banner for the user's selected or intended chain is shown, rather than showing all configured campaigns.

Modified banner selection logic to show only the intended chain's campaign instead of all available campaigns
Added support for Arbitrum limit orders banner campaign
Introduced logic to determine the intended chain ID based on localStorage and URL parameters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/layouts/TopBarNotify.tsx	Updated to use campaign-specific chain ID for localStorage operations instead of current chain ID
src/layouts/MainLayout.tsx	Added intended chain ID detection logic and filtering to show only relevant campaigns

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-02T09:26:13Z

src/layouts/TopBarNotify.tsx

+    const firstChainId = chainIds[0];
+    return firstChainId ? campaigns[firstChainId] || null : null;


The logic assumes the first chain ID from Object.keys() is the intended campaign, but Object.keys() order is not guaranteed to be consistent. This could lead to unpredictable banner selection when multiple campaigns are available.

Suggested change

const firstChainId = chainIds[0];

return firstChainId ? campaigns[firstChainId] || null : null;

if (chainIds.length === 0) return null;

if (currentChainId && campaigns[currentChainId]) {

return campaigns[currentChainId];

}

// fallback: select the campaign with the lowest chainId

const minChainId = Math.min(...chainIds);

return campaigns[minChainId] || null;

Copilot · 2025-10-02T09:26:14Z

src/layouts/MainLayout.tsx

+  const filteredCampaigns: NetworkCampaigns = isCampaignChainId(intendedChainId)
+    ? { [intendedChainId]: campaignConfigs[intendedChainId]! }
+    : {};


Using non-null assertion operator (!) without proper null checking could cause runtime errors if campaignConfigs[intendedChainId] is undefined. Consider using optional chaining or explicit null checking.

Suggested change

const filteredCampaigns: NetworkCampaigns = isCampaignChainId(intendedChainId)

? { [intendedChainId]: campaignConfigs[intendedChainId]! }

: {};

const campaign = campaignConfigs[intendedChainId];

const filteredCampaigns: NetworkCampaigns =

isCampaignChainId(intendedChainId) && campaign !== undefined

? { [intendedChainId]: campaign }

: {};

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-02T09:29:43Z

src/layouts/MainLayout.tsx

+  const campaignConfigs = getCampaignConfigs(openSwitch, openMarket);
+
+  const intendedChainId = getIntendedChainId();
+
+  const isCampaignChainId = (chainId: ChainId): chainId is CampaignChainId => {
+    return chainId in campaignConfigs;
+  };
+
+  const filteredCampaigns: NetworkCampaigns = isCampaignChainId(intendedChainId)
+    ? { [intendedChainId]: campaignConfigs[intendedChainId]! }
+    : {};


Keep banner campaigns in sync with market changes

The new filteredCampaigns is derived from getIntendedChainId() using only localStorage/URL and is computed once in MainLayout. Because this component subscribes only to setCurrentMarket, it never re-renders when the user switches markets or when a marketName query param overrides a stale localStorage value. Meanwhile TopBarNotify now shows the first entry it receives, so after the initial render the banner stays locked to whatever chain was chosen at load time (e.g. start on mainnet, switch to Base, but the mainnet campaign continues to display). The banner logic therefore regresses compared to before. Consider deriving the campaign from the store’s currentChainId or recomputing filteredCampaigns when the selected market changes.

Useful? React with 👍 / 👎.

github-actions · 2025-10-02T11:09:00Z

Ipfs hash: bafybeiddudmrevjy46gxun3qz7kxvs2r7u74o7b5hivnz2rmkmmky7u4wy
Ipfs preview link: https://bafybeiddudmrevjy46gxun3qz7kxvs2r7u74o7b5hivnz2rmkmmky7u4wy.ipfs.cf-ipfs.com/

github-actions · 2025-10-02T11:09:01Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-10-02T11:20:37Z

Ipfs hash: bafybeiaagjgjojbpdvsfe43bcvvuxiustpldnkolgtvijojtoticgmw6w4
Ipfs preview link: https://bafybeiaagjgjojbpdvsfe43bcvvuxiustpldnkolgtvijojtoticgmw6w4.ipfs.cf-ipfs.com/

github-actions · 2025-10-02T11:20:53Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-10-02T14:31:19Z

Ipfs hash: bafybeifg4yojo7wgcqcm4ficwoq5jtpytkriatcvew5uwirer37ugk2qsa
Ipfs preview link: https://bafybeifg4yojo7wgcqcm4ficwoq5jtpytkriatcvew5uwirer37ugk2qsa.ipfs.cf-ipfs.com/

github-actions · 2025-10-02T14:31:35Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-02T14:43:26Z

src/layouts/TopBarNotify.tsx

  };

  const currentCampaign = getCurrentCampaign();
+  const campaignChainId = currentChainId;


The variable campaignChainId is redundant as it simply aliases currentChainId. Consider removing this variable and using currentChainId directly throughout the component to reduce unnecessary indirection.

Copilot · 2025-10-02T14:43:26Z

src/layouts/TopBarNotify.tsx

+      // Use stored preference for this chain
+      setShowWarning(warningBarOpen !== 'false');
+    }
+  }, [currentCampaign, campaignChainId, currentChainId]);


The dependency array includes both campaignChainId and currentChainId which are the same value. Since campaignChainId is just an alias for currentChainId, only currentChainId should be included in the dependency array.

Suggested change

}, [currentCampaign, campaignChainId, currentChainId]);

}, [currentCampaign, currentChainId]);

github-actions · 2025-10-02T15:12:01Z

Ipfs hash: bafybeig4nobpcd74xl745pcx5jweyx4x7od5kjwzh2tqqxiptgp6wdgg4e
Ipfs preview link: https://bafybeig4nobpcd74xl745pcx5jweyx4x7od5kjwzh2tqqxiptgp6wdgg4e.ipfs.cf-ipfs.com/

github-actions · 2025-10-02T15:12:07Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mgrabina · 2025-10-02T15:14:42Z

src/layouts/MainLayout.tsx

  };

-  const campaignConfigs = getCampaignConfigs(openMarket);
+  const campaignConfigs = getCampaignConfigs(openSwitch, openMarket);


would move getCampaignConfigs to a hook useBannerCampaigns so we can get openSwitch (or others in the future) right in there and just pass the chain id

done in 33af445

mgrabina · 2025-10-02T15:15:18Z

src/layouts/MainLayout.tsx

+  icon: string;
+}
+
+type CampaignChainId = ChainId.base | ChainId.mainnet | ChainId.arbitrum_one;


why not just use generic ChainId if down here we use Partial of chains ids

yeah good point 33af445

mgrabina · 2025-10-02T15:15:48Z

src/layouts/MainLayout.tsx

+  buttonText: string;
+  buttonAction: ButtonAction;
+  bannerVersion: string;
+  icon: string;


does it make sense to make the icon optional for future solo-text campaings

yes 33af445

mgrabina · 2025-10-02T15:23:35Z

src/layouts/MainLayout.tsx

+    // Priority 3: URL params marketName
+    const urlMarket = getQueryParameter('marketName');
+    if (urlMarket && marketsData[urlMarket as CustomMarket]) {
+      return marketsData[urlMarket as CustomMarket].chainId;
+    }


shouldn't this be prioritized e.g. someone opens a shared link but been using other network

mgrabina · 2025-10-02T15:24:53Z

src/layouts/MainLayout.tsx

-  //   icon: '/icons/networks/arbitrum.svg',
-  // },
+  [ChainId.arbitrum_one]: {
+    notifyText: 'Limit orders are now live on Arbitrum',


not sure how translations work but can we ensure banner messages will be translated this way? otherwise we can set notifyText type as react node and just use

i see
` {currentCampaign.notifyText}

`
just checking if it's enough

yeah we dont really use translations much but added b2f5f50

mgrabina · 2025-10-02T15:25:35Z

src/layouts/MainLayout.tsx

  openMarket: (market: CustomMarket) => void
-) => ({
+): CampaignConfigs => ({
  [ChainId.base]: {


nit/v2: we can leverage vercel configs or amplitude feature flags to automatically change campaings without commiting new code

mgrabina · 2025-10-02T15:27:41Z

src/layouts/TopBarNotify.tsx

+  useEffect(() => {
+    if (showWarning) {
+      const timer = setTimeout(() => {
+        setSlideIn(true);
+      }, 100);
+
+      return () => clearTimeout(timer);
+    } else {
+      setSlideIn(false);
    }
-  }, [currentCampaign, currentChainId]);
+  }, [showWarning]);


cant this be replaced by a showWarning fn that has the timeout inside?

mgrabina · 2025-10-02T15:34:21Z

src/layouts/TopBarNotify.tsx

feat: improve banner logic

7637fee

foodaka requested review from Copilot, grothem and mgrabina October 2, 2025 09:25

Copilot AI reviewed Oct 2, 2025

View reviewed changes

vercel bot deployed to Preview October 2, 2025 09:27 View deployment

chatgpt-codex-connector bot reviewed Oct 2, 2025

View reviewed changes

fix: banner improvements

ce96b40

vercel bot deployed to Preview October 2, 2025 11:04 View deployment

chore: ux nit

d314847

vercel bot deployed to Preview October 2, 2025 11:16 View deployment

fix: ux nits and simplify

d77ee89

vercel bot deployed to Preview October 2, 2025 14:26 View deployment

foodaka requested a review from Copilot October 2, 2025 14:42

Copilot AI reviewed Oct 2, 2025

View reviewed changes

fix: nits

fcad203

vercel bot deployed to Preview October 2, 2025 15:07 View deployment

mgrabina reviewed Oct 2, 2025

View reviewed changes

foodaka added 2 commits October 3, 2025 16:32

feat: move banner to hook

33af445

chore: pr feedback

b2f5f50

vercel bot had a problem deploying to Preview October 3, 2025 15:56 Failure

		const firstChainId = chainIds[0];
		return firstChainId ? campaigns[firstChainId] \|\| null : null;

-    const firstChainId = chainIds[0];
-    return firstChainId ? campaigns[firstChainId] || null : null;
+    if (chainIds.length === 0) return null;
+    if (currentChainId && campaigns[currentChainId]) {
+      return campaigns[currentChainId];
+    }
+    // fallback: select the campaign with the lowest chainId
+    const minChainId = Math.min(...chainIds);
+    return campaigns[minChainId] || null;

	}, [currentCampaign, campaignChainId, currentChainId]);
	}, [currentCampaign, currentChainId]);

feat: improve banner logic #2693

Are you sure you want to change the base?

feat: improve banner logic #2693

Uh oh!

Conversation

foodaka commented Oct 2, 2025

General Changes

Developer Notes

Reviewer Checklist

Uh oh!

vercel bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

vercel bot commented Oct 2, 2025 •

edited

Loading