Skip to content

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space commented Sep 23, 2025

Signed-off-by: Keshav Priyadarshi <[email protected]>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks++ @keshav-space! Looking good.
See comments for your consideration.

- Scope scanpipe import to avoid Django's ImproperlyConfigured error during tests.

Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Copy link
Member Author

keshav-space commented Sep 26, 2025

@AyanSinhaMahapatra reviews are addressed. https://github.com/keshav-space/minecode-data-nuget is the test repo with mined NuGet PURLs. Will add a separate PR in ScanCodeio for improvements in how we commit and push to FederatedCode.

@keshav-space
Copy link
Member Author

Also see this PR in ScanCode.io for improvents to how we commit and push change to FederatedCode. aboutcode-org/scancode.io#1888

Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
- Doing it other way would cause test to fail each time a new tag is released to PurlDB.

Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space keshav-space force-pushed the 667_mine_nuget_pipeline branch from 8cd43aa to e933efd Compare September 29, 2025 14:15
@keshav-space keshav-space force-pushed the 667_mine_nuget_pipeline branch from 796f336 to 427202e Compare September 29, 2025 15:13
@AyanSinhaMahapatra
Copy link
Member

Thanks @keshav-space, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 26bf2d9 into main Oct 1, 2025
1 of 6 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the 667_mine_nuget_pipeline branch October 1, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

purl-next: Collect PURLs for NuGet ecosystem
2 participants