Fix resolution issues #248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
force-pushed
the
fix-resolution-issues
branch
2 times, most recently
from
5a82762 to
5767cf6
Compare
Signed-off-by: Martin Nonnenmacher <[email protected]>
Use the list of linux platforms as defined in utils_pypi for testing, instead of redefining the list in the test. This ensures that newly added platforms are tested and fixes the problem that the list in the test was already outdated. Signed-off-by: Martin Nonnenmacher <[email protected]>
For example, the platform is used by open3d 19.0.0 [1]. [1]: https://pypi.org/project/open3d/0.19.0/#files Signed-off-by: Martin Nonnenmacher <[email protected]>
By default, the check if an empty specifier contains a prerelease version returns `false`. This made the `is_valid_version()` check for prerelease versions fail, when there is also a requirement with a non-empty specifier. In this case, the previous logic detected a conflict of the prerelease version and the empty specifier. Fix this by explicitly allowing prerelease versions when checking if a specifier contains a version. Note that the function that collects candidates for a dependency still ignores prerelease versions if any release versions are available, as required by the specs [1]. [1]: https://packaging.python.org/en/latest/specifications/version-specifiers/#handling-of-pre-releases Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
fix-resolution-issues
branch
from
5767cf6 to
418962d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues with dependency resolution:
See the commit messages for details.