-
-
Notifications
You must be signed in to change notification settings - Fork 607
add extra-phrase
in rules
#4518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
add extra-phrase
in rules
#4518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alok1304 thanks for the PR, but these changes are not mergable.
See #4515 (comment) for more details on why you cannot:
- replace named entitites with extra words markers
- deprecate rules
See also alok1304/mark-extra-phrase#1 :)
this list of conditions and the following Disclaimer in the documentation | ||
and/or other materials provided with the distribution. | ||
. | ||
. Neither the name of Agere Systems Inc. nor the names of the contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot replace these named entities with extra words markers, this has a huge performance hit. See #4515 (comment) for more details.
Signed-off-by: Alok Kumar <[email protected]>
This reverts commit ad4d85c. Signed-off-by: Alok Kumar <[email protected]>
41f3684
to
e5ef1dd
Compare
Signed-off-by: Alok Kumar <[email protected]>
Some test cases may be failing because the previous pr is not merged yet. |
Reference #4515
Updated..
This will be merge after #4432
In this PR, I added
extra-phrase
maker in rules. I am doing bylicense-expression
wise. First i am doing forbsd-new
license_expression
.Introducing new repo: (What they do?) named-entity-utils
Named-Entity Removal:
Duplicate Rule Detection:
A detailed README is included with instructions on how to set up and run the tool.
Processing Steps for BSD-New(eg) Rules
named-entity-utils
.extra-phrase
marker there.extra-phrase
marker at the positionnamed-entity
.named-entity
is not actually a named-entity, then do not modify that rule (no new rule, no extra-phrase).For
bsd-new
license we got these duplicate rules after removingnamed-entity
from all rules ofbsd-new
license.File:
bsd-new_duplicates_rules.json
Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar [email protected]