Skip to content

defer close DialResp channel to avoid dangling go routines #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

defer close DialResp channel to avoid dangling go routines #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b87b53
defer close DialResp channel to avoid dangling go routines
gabrielmocan May 22, 2023
d36c811
get rid of goroutine
gabrielmocan May 24, 2023
5b812a9
fix while typo
gabrielmocan May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 10 additions & 49 deletions zabbix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"encoding/binary"
"encoding/json"
"fmt"
"io/ioutil"
"io"
"net"
"time"
)
Expand Down Expand Up @@ -70,64 +70,25 @@ func (s *Sender) getHeader() []byte {
return []byte("ZBXD\x01")
}

// Method Sender class, resolve uri by name:port.
func (s *Sender) getTCPAddr() (iaddr *net.TCPAddr, err error) {
// format: hostname:port
addr := fmt.Sprintf("%s:%d", s.Host, s.Port)

// Resolve hostname:port to ip:port
iaddr, err = net.ResolveTCPAddr("tcp", addr)
if err != nil {
err = fmt.Errorf("Connection failed: %s", err.Error())
return
}

return
}

// Method Sender class, make connection to uri.
func (s *Sender) connect() (conn *net.TCPConn, err error) {

type DialResp struct {
Conn *net.TCPConn
Error error
}

// Open connection to zabbix host
iaddr, err := s.getTCPAddr()
func (s *Sender) connect() (tcpConn *net.TCPConn, err error) {
// parses addr as "hostname:port"
addr := fmt.Sprintf("%s:%d", s.Host, s.Port)
// resolves hostname, dials TCP and handles timeout
d := net.Dialer{Timeout: 5 * time.Second}
conn, err := d.Dial("tcp", addr)
if err != nil {
return
}

// dial tcp and handle timeouts
ch := make(chan DialResp)

go func() {
conn, err = net.DialTCP("tcp", nil, iaddr)
ch <- DialResp{Conn: conn, Error: err}
}()

select {
case <-time.After(5 * time.Second):
err = fmt.Errorf("Connection Timeout")
case resp := <-ch:
if resp.Error != nil {
err = resp.Error
break
}

conn = resp.Conn
}

tcpConn, _ = conn.(*net.TCPConn)
return
}

// Method Sender class, read data from connection.
func (s *Sender) read(conn *net.TCPConn) (res []byte, err error) {
res = make([]byte, 1024)
res, err = ioutil.ReadAll(conn)
res, err = io.ReadAll(conn)
if err != nil {
err = fmt.Errorf("Error whule receiving the data: %s", err.Error())
err = fmt.Errorf("error while receiving the data: %s", err.Error())
return
}

Expand Down