Skip to content

Conversation

complexspaces
Copy link

1Password is moving this repository into the OSS domain to allow for others to use resources in it more freely. See #13 for confirmation of copyright eligibility, etc.

This PR also implements a new CLA, ensuring that all contributions going forward have a clear licensing state.

Closes #13

Copy link
Contributor

@jpgoldberg jpgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not anticipated that I would request a change, but see my comment about the copyright date.

@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024 1Password
Copy link
Contributor

@jpgoldberg jpgoldberg Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, but I think the copyright data should include 2018 as well as 2024. Even if the licensing is new, the copyright should include the creation and modification datas.

Copy link
Author

@complexspaces complexspaces Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any objections. Something like this then?

Suggested change
Copyright (c) 2024 1Password
Copyright (c) 2018, 2024 1Password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicitly adopt an open source license

2 participants