Skip to content

Fix: Tag taxonomy returns empty array #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Tag taxonomy returns empty array #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e36df4
Fix: Tag taxonomy returns empty array
Koli14 Feb 27, 2020
8bf30e2
Merge branch 'airesvsg:master' into master
Koli14 Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions v3/lib/endpoints/class-acf-to-rest-api-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ public function register_routes() {
}

public function register_field() {
register_rest_field( $this->type, 'acf', array(
$type = ( 'post_tag' === $this->type ) ? 'tag' : $this->type;
register_rest_field( $type, 'acf', array(
'get_callback' => array( $this, 'register_field_callback' ),
'schema' => array(
'description' => __( 'Expose advanced custom fields.', 'acf-to-rest-api' ),
Expand Down Expand Up @@ -123,7 +124,7 @@ public function update_item( $request ) {
update_field( $field['key'], $value, $item['id'] );
} else {
do_action( 'acf/update_value', $value, $item['id'], $field );
}
}
}
}
}
Expand All @@ -136,13 +137,13 @@ public function update_item( $request ) {

public function rest_insert( $object, $request, $creating ) {
if ( $request instanceof WP_REST_Request ) {
$id = $this->acf->get_id( $object );
$id = $this->acf->get_id( $object );
if ( ! $id ) {
$id = $this->acf->get_id( $request );
}
$request->set_param( 'id', $id );
}

return $this->update_item( $request );
}

Expand Down