Geomfields Reorg for Issue #28 #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tSuite filter. Remove from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alec,
I tested this out by spinning up a virtual server without
PostGIS( or dependencies ) and withoutpsycopg2installed. Runningpython example/manage.py testruns the normal tests without error. Please try this yourself before the merge to verify. Fix for #28Also, give some thought about the reorganization I did. I changed things from your last commit. If you think this is not the ideal pattern, then I'm wide open to change it.
The biggest change from your last commit was that I moved geo tests from
geoexample/test/test_geo_modelresource_methods_and_filters.pyback into theconduit/test/folder. They felt better there. I figured it's good to keep related tests in the same place since they are all about testing conduit. I then created two TestRunner classes inconduit/test/testrunners.py-- one runs the standard tests ( filters out the geo related ones ) and the other only runs the geo tests. These test runners were added to each app's settting file.If you think it's better to leave out the test runners in favor of splitting tests up between apps, then I can do that.