Skip to content

Conversation

@florrdv
Copy link
Contributor

@florrdv florrdv commented Nov 13, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on adding functionality to export private keys for accounts, including support for multi-owner organizations. It introduces new interfaces and methods to handle the export process securely.

Detailed summary

  • Added ExportPrivateKeyParams and MultiOwnerExportPrivateKeyParams interfaces.
  • Implemented exportPrivateKey method to export private keys based on account type.
  • Introduced experimental_multiOwnerExportPrivateKey method for multi-owner organizations.
  • Integrated decryptExportBundle for securing exported data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
aa-sdk-ui-demo Ready Ready Preview Comment Nov 13, 2025 9:59pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Nov 13, 2025, 9:55 PM

Copy link
Contributor

@jakehobbs jakehobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, but left a question in slack

opts.type === "ETHEREUM"
? "ADDRESS_FORMAT_ETHEREUM"
: "ADDRESS_FORMAT_SOLANA";
const keyFormat = opts.type === "ETHEREUM" ? "HEXADECIMAL" : "SOLANA";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol that the key format type is solana here and not b58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants