-
Notifications
You must be signed in to change notification settings - Fork 199
feat: key export #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: key export #2249
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🌿 Documentation Preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me, but left a question in slack
| opts.type === "ETHEREUM" | ||
| ? "ADDRESS_FORMAT_ETHEREUM" | ||
| : "ADDRESS_FORMAT_SOLANA"; | ||
| const keyFormat = opts.type === "ETHEREUM" ? "HEXADECIMAL" : "SOLANA"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol that the key format type is solana here and not b58
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on adding functionality to export private keys for accounts, including support for multi-owner organizations. It introduces new interfaces and methods to handle the export process securely.
Detailed summary
ExportPrivateKeyParamsandMultiOwnerExportPrivateKeyParamsinterfaces.exportPrivateKeymethod to export private keys based on account type.experimental_multiOwnerExportPrivateKeymethod for multi-owner organizations.decryptExportBundlefor securing exported data.